Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/quick-humans-bathe.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"overlay-kit": patch
---

feat: Change to allow each overlay provider to have a unique event ID

Each overlay provider now uses a unique event ID instead of relying on shared global identifiers.

This change improves event handling accuracy and avoids potential collisions when managing multiple overlays from different providers.
It is backward-compatible for existing overlays that do not explicitly set a provider-specific ID.
4 changes: 3 additions & 1 deletion packages/src/context/provider/index.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import { useCallback, useEffect, useReducer, type PropsWithChildren } from 'react';
import { ContentOverlayController } from './content-overlay-controller';
import { type OverlayEvent, createOverlay } from '../../event';
import { randomId } from '../../utils/random-id';
import { createOverlaySafeContext } from '../context';
import { overlayReducer } from '../reducer';

export function createOverlayProvider() {
const { useOverlayEvent, ...overlay } = createOverlay();
const overlayId = randomId();
const { useOverlayEvent, ...overlay } = createOverlay(overlayId);
const { OverlayContextProvider, useCurrentOverlay, useOverlayData } = createOverlaySafeContext();

function OverlayProvider({ children }: PropsWithChildren) {
Expand Down
4 changes: 2 additions & 2 deletions packages/src/event.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ type OpenOverlayOptions = {
overlayId?: string;
};

export function createOverlay() {
const [useOverlayEvent, createEvent] = createUseExternalEvents<OverlayEvent>('overlay-kit');
export function createOverlay(overlayId: string) {
const [useOverlayEvent, createEvent] = createUseExternalEvents<OverlayEvent>(`${overlayId}/overlay-kit`);

const open = (controller: OverlayControllerComponent, options?: OpenOverlayOptions) => {
const overlayId = options?.overlayId ?? randomId();
Expand Down
2 changes: 1 addition & 1 deletion packages/src/utils/create-overlay-context.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { createOverlayProvider } from '../context/provider';

export const { overlay, OverlayProvider, useCurrentOverlay, useOverlayData } = experimental_createOverlayContext();
export const { overlay, OverlayProvider, useCurrentOverlay, useOverlayData } = createOverlayProvider();

// eslint-disable-next-line @typescript-eslint/naming-convention
export function experimental_createOverlayContext() {
Expand Down