refactor: migrate event based store #149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issues with component unmounting caused by conflicts between useSyncExternalStore (uSES) and React's scheduler.
We've replaced the useSyncExternalStore-based state management with a useReducer and event-based system to stabilize component lifecycle management.
Related Issue: Fixes #148
Changes
createUseExternalEvents)Motivation and Context
The previous implementation had several issues:
These issues stemmed from differences between React's scheduling and how useSyncExternalStore works. This PR addresses these fundamental problems by changing the state management approach.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist
Further Comments
This change addresses fundamental issues with React scheduling and state management, overcoming the limitations of the useSyncExternalStore-based implementation to provide more stable component lifecycle management. Key improvements include:
The critical insight was that we needed to abandon useSyncExternalStore (which doesn't work well even with flushSync) and implement our own queue management system that works independently from React's scheduler.