Fix: Add missing syntax and normalize Auth Token usage #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Seol-JY is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
milooy
reviewed
Feb 2, 2025
| @@ -69,7 +69,7 @@ | |||
| 例如，假设一个域(`Domain1`)的子代码中引用另一个域(`Domain2`)的源代码，如下所示： | |||
|
|
|||
| ```typescript | |||
| import { useFoo } '../../../Domain2/hooks/useFoo' | |||
| import { useFoo } from '../../../Domain2/hooks/useFoo' | |||
Kyujenius
pushed a commit
to Kyujenius/frontend-fundamentals
that referenced
this pull request
Feb 3, 2025
* fix: Add missing 'from' keyword in import statement * fix: Add missing period in email validation error message(ko) * fix: add auth token to HTTP header
milooy
pushed a commit
that referenced
this pull request
Feb 4, 2025
* fix: change LCP image from png to webp * docs: 간체 중국어 번역 (#120) * chore: create ch files * docs: translate into simplified chinese * docs: translate into simplified chinese * docs: translate into simplified chinese * docs: translate into simplified chinese * docs: translate into simplified chinese * docs: translate into simplified chinese * refactor: substitute with suitable terms * docs: translate into simplified chinese * feat: add chSearch * fix: change chSearch option * fix: fix typo with inspection * �fix: fix typo in hidden-logic.md 同时 -> 同事 Co-authored-by: Jinyeong Seol <wlsdud5654@gmail.com> * feat: implement dark mode image support in markdown * docs: improve item-edit-modal.md by adding abstraction concepts * fix: correct localized link --------- Co-authored-by: Jinyeong Seol <wlsdud5654@gmail.com> * Fix: Corrected localized link to Amazon (#141) - The link was still redirecting to Yes24, so the link was updated properly * Fix: Correct import path and Add Chinese on Giscus language (#144) * Fix: Ensure Giscus supports Chinese * Fixed an issue where the Chinese locale was not applied in Giscus * Fix: Correct import path for Chinese locale * Fixed an incorrect import path in ( → ). * Revert: yarn.lock * �Fix: Add missing syntax and normalize Auth Token usage (#145) * fix: Add missing 'from' keyword in import statement * fix: Add missing period in email validation error message(ko) * fix: add auth token to HTTP header * fix: resolve badge component rendering issue by extending default theme (#146) * feat: add webp Image in chinese ver. --------- Co-authored-by: Owon <chlehdnjs@gmail.com> Co-authored-by: Jinyeong Seol <wlsdud5654@gmail.com> Co-authored-by: 𝒄𝒍 𝒊 𝒄 𝒆 <131771046+clicelee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Key Changes
Fixes three syntax issues:
Code ExampleandWork on Improvingsections, I added Auth Token toCode Example. Based on the document context, I believe adding Auth Token was appropriate - could you confirm if this assessment is correct? - 69a4ab2🖼️ Before and After Comparison
Simple text corrections in documentation files. No visual changes.