feat(sortedIndexOf): Implement compat/sortedIndexOf#971
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for your contribution! I will review it within the weekend. |
|
@dayongkr Of course! If there's anything incorrect or that needs to be fixed, please feel free to let me know! If possible, I'd love to contribute even more! |
Co-authored-by: Dayong Lee <dayong@toss.im>
Co-authored-by: Dayong Lee <dayong@toss.im>
Co-authored-by: Dayong Lee <dayong@toss.im>
|
This seems to be your first contribution, and it's also my first review 😄 I can see that you put a lot of thought into your work! If you plan to contribute more in the future, I recommend joining our Discord, where we actively communicate. |
|
Thanks for inviting me ! 😄 It gives me strength! |
Co-authored-by: Dayong Lee <dayong@toss.im>
Co-authored-by: Dayong Lee <dayong@toss.im>
dayongkr
left a comment
There was a problem hiding this comment.
The examples modifications are minor, so I will make the adjustments myself!
Welcome to your first contribution, and huge thanks!!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #971 +/- ##
==========================================
+ Coverage 99.37% 99.40% +0.03%
==========================================
Files 381 382 +1
Lines 3371 3378 +7
Branches 1002 1004 +2
==========================================
+ Hits 3350 3358 +8
+ Misses 20 19 -1
Partials 1 1 🚀 New features to boost your workflow:
|
|
@dayongkr |
I added
sortedIndexOfin compat layer using by sortedIndex which isResolves: #846
I conducted more extensive testing, comparing all results with the existing Lodash functions. My tests covered a wider range of scenarios, and in all cases, my implementation produced identical results to the original Lodash functions.
Test