Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropWhile): dropWhile returns the whole array when every element does not match the predicate #49

Merged
merged 3 commits into from
Jun 15, 2024

Conversation

changwoolab
Copy link
Contributor

Thank you for making this lib!
I found an edge case for dropWhile function and I fixed it.

Copy link

vercel bot commented Jun 14, 2024

@changwoolab is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

src/array/dropWhile.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing our bug!

@raon0211 raon0211 changed the title fix[dropWhile]: fix a bug in dropWhile function fix(dropWhile): dropWhile returns the whole array when every element does not match the predicate Jun 15, 2024
@raon0211 raon0211 merged commit 212f970 into toss:main Jun 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants