Skip to content

fix: add missing forEach/countBy exports to map and set - #1695

Merged
raon0211 merged 1 commit into
toss:mainfrom
umsungjun:fix/map-set-missing-exports
Apr 29, 2026
Merged

raon0211 merged 1 commit into
toss:mainfrom
umsungjun:fix/map-set-missing-exports

Conversation

@umsungjun

Copy link
Copy Markdown
Contributor

Implementations, tests, and docs already exist, but the exports were missing from the index files, so added them.

Copilot AI review requested due to automatic review settings April 23, 2026 07:04
@vercel

vercel Bot commented Apr 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
es-toolkit Ready Ready Preview, Comment Apr 23, 2026 7:10am

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes missing public exports for existing countBy/forEach utilities in the map and set modules by updating their respective index barrels so consumers can import these functions via the module entrypoints.

Changes:

  • Export forEach from src/set/index.ts.
  • Export countBy and forEach from src/map/index.ts.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/set/index.ts Adds the missing forEach re-export for the set utilities barrel.
src/map/index.ts Adds the missing countBy and forEach re-exports for the map utilities barrel.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.85%. Comparing base (95111dd) to head (cbe5d73).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1695   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files         498      498           
  Lines        4667     4667           
  Branches     1354     1354           
=======================================
  Hits         4660     4660           
  Misses          7        7           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@raon0211 raon0211 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@raon0211
raon0211 merged commit 50d799e into toss:main Apr 29, 2026
8 of 14 checks passed

This branch was successfully deployed

1 active deployment
Preview — cbe5d73a Deployed Apr 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants