Skip to content

Conversation

wo-o29
Copy link
Contributor

@wo-o29 wo-o29 commented Oct 12, 2025

Summary

This PR improves the return value description for the mapValues function across all language documentation (English, Korean, Japanese, and Simplified Chinese). The Korean documentation previously had the return value description in English, and all language versions now provide more specific descriptions that explicitly mention the getNewValue function.

Changes

  • Updated Korean documentation to use Korean language for the return value description
  • Enhanced all language versions to explicitly reference the getNewValue function in the return value description
  • Made descriptions more specific and clear about how values are transformed

@Copilot Copilot AI review requested due to automatic review settings October 12, 2025 06:34
Copy link

vercel bot commented Oct 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
es-toolkit Ready Ready Preview Comment Oct 12, 2025 10:48am

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates documentation for the mapValues function across all language versions to improve the return value descriptions. The changes make the descriptions more specific by explicitly referencing the getNewValue function and ensure consistency between languages.

  • Translated Korean documentation from English to Korean for the return value description
  • Enhanced all language versions to explicitly mention the getNewValue function in return value descriptions
  • Made descriptions more specific about how values are transformed

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
docs/zh_hans/reference/object/mapValues.md Updated Chinese return value description to reference getNewValue function
docs/reference/object/mapValues.md Enhanced English return value description with getNewValue function reference
docs/ko/reference/object/mapValues.md Translated return value description from English to Korean and added getNewValue reference
docs/ja/reference/object/mapValues.md Updated Japanese return value description to reference getNewValue function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.90%. Comparing base (21bd853) to head (5393bd7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1464   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files         468      468           
  Lines        4439     4439           
  Branches     1309     1309           
=======================================
  Hits         4435     4435           
  Misses          4        4           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants