fix: resolve circular import between isMatch and isMatchWith #1446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1392
This PR resolves the circular import issue between
isMatch
andisMatchWith
functions.Changes
import { isMatch }
statement fromsrc/compat/predicate/isMatchWith.ts
isMatchWith
when no comparator is provided from callingisMatch(target, source)
to callingisMatchWith(target, source, () => undefined)
isMatch
internally callsisMatchWith
with a no-op comparatorThe change is functionally equivalent since
isMatch
simply delegates toisMatchWith
with a comparator that always returnsundefined
, triggering the default matching behavior.