feat(invert): add invert #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wondonghwi is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
hautest
reviewed
Jul 4, 2024
benchmarks/invert.bench.ts
Outdated
| invertByLodash(object); | ||
| }); | ||
|
|
||
| bench('Custom invert', () => { |
There was a problem hiding this comment.
custom is good, but what do you think about doing it with es-toolkit/invert ?
There was a problem hiding this comment.
@hautest
Thank you for the good comments, I've made the corrections more clearly!
jgjgill
reviewed
Jul 4, 2024
src/object/invert.ts
Outdated
| * invert({ a: Symbol('sym1'), b: Symbol('sym2') }); // { [Symbol('sym1')]: 'a', [Symbol('sym2')]: 'b' } | ||
| */ | ||
|
|
||
| export function invert<K extends string | number | symbol, V extends string | number | symbol>( |
There was a problem hiding this comment.
I think you can use PropertyKey.
They're the same, but I think it's more readable.
Suggested change
| export function invert<K extends string | number | symbol, V extends string | number | symbol>( | |
| export function invert<K extends PropertyKey, V extends PropertyKey>( |
There was a problem hiding this comment.
@jgjgill
I've made the modifications. Thank you for the good comments. I think it's more readable
raon0211
reviewed
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #116
I added an invert function to the es-toolkit library. The invert function takes an object as input and returns a new object where the keys and values are swapped. This functionality is available in lodash but was not present in es-toolkit.
The invert function is particularly useful when you need to reverse the mapping of an object. For example, given an object with key-value pairs, the invert function will produce a new object where the original values become the keys and the original keys become the values.
For reference, you can see the lodash invert function here.