-
Notifications
You must be signed in to change notification settings - Fork 539
Description
Hi,
First of all, thank you very much for creating this nice library! It's really awesome and a better alternative to Lodash, and I think that the nearly 14M+ downloads per week confirm that.
I just wanted to raise a topic, the fact that for some private projects that use this library, the security teams at some companies require that open source libraries meet some minimum requirements in terms of security. For this, a common tool to assess that is the OpenSSF Scorecard tool.
I've ran this tool with this repo and it got an aggregate score of 5.4 out of 10. These are the results in detail:
docker run -e GITHUB_AUTH_TOKEN=<some-token> gcr.io/openssf/scorecard:stable --repo=https://github.com/toss/es-toolkit
Status: Downloaded newer image for gcr.io/openssf/scorecard:stable
Starting [CII-Best-Practices]
Starting [Signed-Releases]
Starting [License]
Starting [CI-Tests]
Starting [Maintained]
Starting [Dependency-Update-Tool]
Starting [SAST]
Starting [Packaging]
Starting [Security-Policy]
Starting [Token-Permissions]
Starting [Vulnerabilities]
Starting [Dangerous-Workflow]
Starting [Code-Review]
Starting [Contributors]
Starting [Branch-Protection]
Starting [Fuzzing]
Starting [Pinned-Dependencies]
Starting [Binary-Artifacts]
Check scores:
Finished [Security-Policy]
Finished [Token-Permissions]
Finished [Vulnerabilities]
Finished [Dangerous-Workflow]
Finished [Code-Review]
Finished [Contributors]
Finished [Branch-Protection]
Finished [Fuzzing]
Finished [Pinned-Dependencies]
Finished [Binary-Artifacts]
Finished [CII-Best-Practices]
Finished [Signed-Releases]
Finished [License]
Finished [CI-Tests]
Finished [Maintained]
Finished [Dependency-Update-Tool]
Finished [SAST]
Finished [Packaging]
RESULTS
-------
Aggregate score: 5.4 / 10So I believe there are some low hanging fruits that could be fixed to improve the score:
- pin dependencies to an exact version
- upgrade vulnerable dependencies, and some of them perhaps might be already fixed in the PRs open by dependabot
- ensure that the project's automated workflows tokens follow the principle of least privilege
- branch protection
IMHO this will be beneficial for everyone, as adoption of this library could increase even more specially in private projects, and consumers can be confident that they are using a library with good security measures.
WDYT?