Skip to content

Conversation

@koic
Copy link
Collaborator

@koic koic commented Mar 4, 2025

Follow-up to rails/rails#54678

This PR supports RuboCop Plugin System:
https://docs.rubocop.org/rubocop/plugin_migration_guide.html

RuboCop (>= 1.72.2) and its extension gems will now require versions that support plugins. This is the same update as rails/rails#54678.

@koic koic force-pushed the support_rubocop_plugin_system branch from b911602 to edd2128 Compare March 4, 2025 06:55
Follow-up to rails/rails#54678

This PR supports RuboCop Plugin System:
https://docs.rubocop.org/rubocop/plugin_migration_guide.html

RuboCop (>= 1.72.2) and its extension gems will now require versions that support plugins.
This is the same update as rails/rails#54678.
@koic koic force-pushed the support_rubocop_plugin_system branch from edd2128 to 85f0385 Compare March 4, 2025 06:57
@koic koic mentioned this pull request Mar 4, 2025
@koic
Copy link
Collaborator Author

koic commented Mar 4, 2025

@toshimaru Plugin support was introduced in RuboCop 1.72. Since rails/rails already uses plugins, this update is being applied to rubocop-rails_config. With this change, the issue in #175 will also be resolved.

@toshimaru
Copy link
Owner

Super cool.

I'll review it after catching up on the RuboCop Plugin System.

Copy link
Owner

@toshimaru toshimaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

The changes for the plugin system are 🆒. 👍


👀 Referenced issues and pull requests I've watched:

@toshimaru toshimaru merged commit ab1adf9 into toshimaru:main Mar 9, 2025
12 checks passed
@koic koic deleted the support_rubocop_plugin_system branch March 9, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants