Skip to content

drivers/gpio PCA9555 - epoll_wait(2) misses first irq after setting an irq mask... #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
metelik wants to merge 1 commit into from
Closed

drivers/gpio PCA9555 - epoll_wait(2) misses first irq after setting an irq mask... #673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions drivers/gpio/gpio-pca953x.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,13 +716,16 @@ static bool pca953x_irq_pending(struct pca953x_chip *chip, u8 *pending)
trigger[i] = (cur_stat[i] ^ old_stat[i]) & chip->irq_mask[i];
if (trigger[i])
trigger_seen = true;

/* We want the current status recorded in the chip->irq stat regardless the
* chip->irq_mask setting in order to have a change detected when the interrupt
* mask gets changed i.e. echo "both" > /sys/class/gpioXYZ/edge */
chip->irq_stat[i] = cur_stat[i];
}

if (!trigger_seen)
return false;

memcpy(chip->irq_stat, cur_stat, NBANK(chip));

for (i = 0; i < NBANK(chip); i++) {
pending[i] = (old_stat[i] & chip->irq_trig_fall[i]) |
(cur_stat[i] & chip->irq_trig_raise[i]);
Expand Down