-
Notifications
You must be signed in to change notification settings - Fork 55.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for VGA devices on I/O hoses other than 0 in the Alpha archit… #1148
base: master
Are you sure you want to change the base?
Conversation
Hi @WesleyA0101! Thanks for your contribution to the Linux kernel! Linux kernel development happens on mailing lists, rather than on GitHub - this GitHub repository is a read-only mirror that isn't used for accepting contributions. So that your change can become part of Linux, please email it to us as a patch. Sending patches isn't quite as simple as sending a pull request, but fortunately it is a well documented process. Here's what to do:
How do I format my contribution?The Linux kernel community is notoriously picky about how contributions are formatted and sent. Fortunately, they have documented their expectations. Firstly, all contributions need to be formatted as patches. A patch is a plain text document showing the change you want to make to the code, and documenting why it is a good idea. You can create patches with Secondly, patches need 'commit messages', which is the human-friendly documentation explaining what the change is and why it's necessary. Thirdly, changes have some technical requirements. There is a Linux kernel coding style, and there are licensing requirements you need to comply with. Both of these are documented in the Submitting Patches documentation that is part of the kernel. Note that you will almost certainly have to modify your existing git commits to satisfy these requirements. Don't worry: there are many guides on the internet for doing this. Where do I send my contribution?The Linux kernel is composed of a number of subsystems. These subsystems are maintained by different people, and have different mailing lists where they discuss proposed changes. If you don't already know what subsystem your change belongs to, the
Make sure that your list of recipients includes a mailing list. If you can't find a more specific mailing list, then LKML - the Linux Kernel Mailing List - is the place to send your patches. It's not usually necessary to subscribe to the mailing list before you send the patches, but if you're interested in kernel development, subscribing to a subsystem mailing list is a good idea. (At this point, you probably don't need to subscribe to LKML - it is a very high traffic list with about a thousand messages per day, which is often not useful for beginners.) How do I send my contribution?Use For more information about using How do I get help if I'm stuck?Firstly, don't get discouraged! There are an enormous number of resources on the internet, and many kernel developers who would like to see you succeed. Many issues - especially about how to use certain tools - can be resolved by using your favourite internet search engine. If you can't find an answer, there are a few places you can turn:
If you get really, really stuck, you could try the owners of this bot, @daxtens and @ajdlinux. Please be aware that we do have full-time jobs, so we are almost certainly the slowest way to get answers! I sent my patch - now what?You wait. You can check that your email has been received by checking the mailing list archives for the mailing list you sent your patch to. Messages may not be received instantly, so be patient. Kernel developers are generally very busy people, so it may take a few weeks before your patch is looked at. Then, you keep waiting. Three things may happen:
Further information
Happy hacking! This message was posted by a bot - if you have any questions or suggestions, please talk to my owners, @ajdlinux and @daxtens, or raise an issue at https://github.com/ajdlinux/KernelPRBot. |
Null Pointer Checks:
Added checks to ensure that critical pointers, such as hwrpb and pu64, are not null, preventing runtime failures.
Use of Macros for Constants:
Replaced hardcoded values (such as 0x3C0 and 0x3DF) with macros (VGA_IO_START and VGA_IO_END), improving readability and facilitating future changes.
Simplification of the default_vga_hose_select Function:
The function was simplified to a single line, making it more concise and easier to understand.
Error Checking in request_resource:
Added a check to ensure that the I/O resource is successfully allocated. If not, an error message is displayed, and the function returns early.
Use of Appropriate Log Levels:
Log messages were updated to use appropriate levels (KERN_ERR for errors and KERN_INFO for informational messages), facilitating debugging and monitoring.
Structuring the for Loop in locate_and_init_vga:
The loop that iterates over PCI devices was simplified, improving readability and reducing code complexity.
Addition of const for Function Pointers:
The function pointer sel_func was marked as const to indicate that it does not modify the pointed data, increasing code safety.
Resource Verification and Error Handling:
Added additional checks to ensure that necessary resources are available before proceeding with VGA initialization.
OBS: I unfortunately could not test at the moment