Skip to content

Commit

Permalink
[NETFILTER]: Fix warnings in ip_nat_snmp_basic.c
Browse files Browse the repository at this point in the history
net/ipv4/netfilter/ip_nat_snmp_basic.c: In function 'asn1_header_decode':
net/ipv4/netfilter/ip_nat_snmp_basic.c:248: warning: 'len' may be used uninitialized in this function
net/ipv4/netfilter/ip_nat_snmp_basic.c:248: warning: 'def' may be used uninitialized in this function
net/ipv4/netfilter/ip_nat_snmp_basic.c: In function 'snmp_translate':
net/ipv4/netfilter/ip_nat_snmp_basic.c:672: warning: 'l' may be used uninitialized in this function
net/ipv4/netfilter/ip_nat_snmp_basic.c:668: warning: 'type' may be used uninitialized in this function

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
davem330 committed Mar 21, 2006
1 parent fb95049 commit edb2c34
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion net/ipv4/netfilter/ip_nat_snmp_basic.c
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ static unsigned char asn1_header_decode(struct asn1_ctx *ctx,
if (!asn1_id_decode(ctx, cls, con, tag))
return 0;

def = len = 0;
if (!asn1_length_decode(ctx, &def, &len))
return 0;

Expand Down Expand Up @@ -669,7 +670,7 @@ static unsigned char snmp_object_decode(struct asn1_ctx *ctx,
unsigned char *eoc, *end, *p;
unsigned long *lp, *id;
unsigned long ul;
long l;
long l;

*obj = NULL;
id = NULL;
Expand Down Expand Up @@ -699,11 +700,13 @@ static unsigned char snmp_object_decode(struct asn1_ctx *ctx,
return 0;
}

type = 0;
if (!snmp_tag_cls2syntax(tag, cls, &type)) {
kfree(id);
return 0;
}

l = 0;
switch (type) {
case SNMP_INTEGER:
len = sizeof(long);
Expand Down

0 comments on commit edb2c34

Please sign in to comment.