Skip to content

Commit

Permalink
driver core: add device_{add|remove}_group() helpers
Browse files Browse the repository at this point in the history
We have helpers that work with NULL terminated array of groups, but many
drivers only create a single supplemental group, and do not want to declare
a group array. Let's provide them with helpers working with a single group.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
dtor authored and gregkh committed Jul 22, 2017
1 parent a7670d4 commit e323b2d
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions include/linux/device.h
Original file line number Diff line number Diff line change
Expand Up @@ -1205,6 +1205,22 @@ extern int __must_check device_add_groups(struct device *dev,
extern void device_remove_groups(struct device *dev,
const struct attribute_group **groups);

static inline int __must_check device_add_group(struct device *dev,
const struct attribute_group *grp)
{
const struct attribute_group *groups[] = { grp, NULL };

return device_add_groups(dev, groups);
}

static inline void device_remove_group(struct device *dev,
const struct attribute_group *grp)
{
const struct attribute_group *groups[] = { grp, NULL };

return device_remove_groups(dev, groups);
}

/*
* Platform "fixup" functions - allow the platform to have their say
* about devices and actions that the general device layer doesn't
Expand Down

0 comments on commit e323b2d

Please sign in to comment.