Skip to content

Commit

Permalink
block: cleanup queue_wc_store
Browse files Browse the repository at this point in the history
Get rid of the local queue_wc_store variable and handling setting and
clearing the QUEUE_FLAG_WC flag diretly instead the if / else if.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20230707094239.107968-2-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Christoph Hellwig authored and axboe committed Jul 17, 2023
1 parent ffe357c commit c4e21bc
Showing 1 changed file with 3 additions and 11 deletions.
14 changes: 3 additions & 11 deletions block/blk-sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -449,21 +449,13 @@ static ssize_t queue_wc_show(struct request_queue *q, char *page)
static ssize_t queue_wc_store(struct request_queue *q, const char *page,
size_t count)
{
int set = -1;

if (!strncmp(page, "write back", 10))
set = 1;
blk_queue_flag_set(QUEUE_FLAG_WC, q);
else if (!strncmp(page, "write through", 13) ||
!strncmp(page, "none", 4))
set = 0;

if (set == -1)
return -EINVAL;

if (set)
blk_queue_flag_set(QUEUE_FLAG_WC, q);
else
blk_queue_flag_clear(QUEUE_FLAG_WC, q);
else
return -EINVAL;

return count;
}
Expand Down

0 comments on commit c4e21bc

Please sign in to comment.