Skip to content

Commit

Permalink
isci: Removing unused variables compiler warnings
Browse files Browse the repository at this point in the history
Newer gcc's are better at identifying "set, but not used" variables.

Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
  • Loading branch information
davejiang authored and djbw committed Jul 3, 2011
1 parent bf482c6 commit 8d2c65c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
8 changes: 0 additions & 8 deletions drivers/scsi/isci/request.c
Original file line number Diff line number Diff line change
Expand Up @@ -211,11 +211,9 @@ static void scu_ssp_reqeust_construct_task_context(
struct scu_task_context *task_context)
{
dma_addr_t dma_addr;
struct scic_sds_controller *controller;
struct scic_sds_remote_device *target_device;
struct scic_sds_port *target_port;

controller = scic_sds_request_get_controller(sds_request);
target_device = scic_sds_request_get_device(sds_request);
target_port = scic_sds_request_get_port(sds_request);

Expand Down Expand Up @@ -384,11 +382,9 @@ static void scu_sata_reqeust_construct_task_context(
struct scu_task_context *task_context)
{
dma_addr_t dma_addr;
struct scic_sds_controller *controller;
struct scic_sds_remote_device *target_device;
struct scic_sds_port *target_port;

controller = scic_sds_request_get_controller(sci_req);
target_device = scic_sds_request_get_device(sci_req);
target_port = scic_sds_request_get_port(sci_req);

Expand Down Expand Up @@ -677,12 +673,10 @@ enum sci_status scic_task_request_construct_ssp(
static enum sci_status scic_io_request_construct_basic_sata(struct scic_sds_request *sci_req)
{
enum sci_status status;
struct scic_sds_stp_request *stp_req;
bool copy = false;
struct isci_request *isci_request = sci_req_to_ireq(sci_req);
struct sas_task *task = isci_request_access_task(isci_request);

stp_req = &sci_req->stp.req;
sci_req->protocol = SCIC_STP_PROTOCOL;

copy = (task->data_dir == DMA_NONE) ? false : true;
Expand Down Expand Up @@ -3190,7 +3184,6 @@ scu_smp_request_construct_task_context(struct scic_sds_request *sci_req,
ssize_t req_len)
{
dma_addr_t dma_addr;
struct scic_sds_controller *scic;
struct scic_sds_remote_device *sci_dev;
struct scic_sds_port *sci_port;
struct scu_task_context *task_context;
Expand All @@ -3202,7 +3195,6 @@ scu_smp_request_construct_task_context(struct scic_sds_request *sci_req,

task_context = scic_sds_request_get_task_context(sci_req);

scic = scic_sds_request_get_controller(sci_req);
sci_dev = scic_sds_request_get_device(sci_req);
sci_port = scic_sds_request_get_port(sci_req);

Expand Down
3 changes: 1 addition & 2 deletions drivers/scsi/isci/task.c
Original file line number Diff line number Diff line change
Expand Up @@ -1358,7 +1358,6 @@ isci_task_request_complete(struct isci_host *ihost,
enum sci_task_status completion_status)
{
struct isci_remote_device *idev = ireq->isci_device;
enum isci_request_status old_state;
struct isci_tmf *tmf = isci_request_access_tmf(ireq);
struct completion *tmf_complete;
struct scic_sds_request *sci_req = &ireq->sci;
Expand All @@ -1367,7 +1366,7 @@ isci_task_request_complete(struct isci_host *ihost,
"%s: request = %p, status=%d\n",
__func__, ireq, completion_status);

old_state = isci_request_change_state(ireq, completed);
isci_request_change_state(ireq, completed);

tmf->status = completion_status;
ireq->complete_in_target = true;
Expand Down

0 comments on commit 8d2c65c

Please sign in to comment.