Skip to content

Commit

Permalink
mfd: tps6594: Add null pointer check to tps6594_device_init()
Browse files Browse the repository at this point in the history
devm_kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure.

Fixes: 325bec7 ("mfd: tps6594: Add driver for TI TPS6594 PMIC")
Suggested-by: Lee Jones <lee@kernel.org>
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Link: https://lore.kernel.org/r/20231208033320.49345-1-chentao@kylinos.cn
Signed-off-by: Lee Jones <lee@kernel.org>
  • Loading branch information
KunWuChan authored and lag-linaro committed Dec 13, 2023
1 parent 4f9b632 commit 825906f
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/mfd/tps6594-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,9 @@ int tps6594_device_init(struct tps6594 *tps, bool enable_crc)
tps6594_irq_chip.name = devm_kasprintf(dev, GFP_KERNEL, "%s-%ld-0x%02x",
dev->driver->name, tps->chip_id, tps->reg);

if (!tps6594_irq_chip.name)
return -ENOMEM;

ret = devm_regmap_add_irq_chip(dev, tps->regmap, tps->irq, IRQF_SHARED | IRQF_ONESHOT,
0, &tps6594_irq_chip, &tps->irq_data);
if (ret)
Expand Down

0 comments on commit 825906f

Please sign in to comment.