Skip to content

Commit

Permalink
llc2: Remove redundant assignment to rc
Browse files Browse the repository at this point in the history
Variable rc is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.

Cleans up the following clang-analyzer warning:

net/llc/llc_station.c:86:2: warning: Value stored to 'rc' is never read
[clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jiapeng Chong authored and davem330 committed Apr 27, 2021
1 parent 3afef8c commit 2342eb1
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions net/llc/llc_station.c
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ static int llc_station_ac_send_xid_r(struct sk_buff *skb)

if (!nskb)
goto out;
rc = 0;
llc_pdu_decode_sa(skb, mac_da);
llc_pdu_decode_ssap(skb, &dsap);
llc_pdu_header_init(nskb, LLC_PDU_TYPE_U, 0, dsap, LLC_PDU_RSP);
Expand Down Expand Up @@ -83,7 +82,6 @@ static int llc_station_ac_send_test_r(struct sk_buff *skb)

if (!nskb)
goto out;
rc = 0;
llc_pdu_decode_sa(skb, mac_da);
llc_pdu_decode_ssap(skb, &dsap);
llc_pdu_header_init(nskb, LLC_PDU_TYPE_U, 0, dsap, LLC_PDU_RSP);
Expand Down

0 comments on commit 2342eb1

Please sign in to comment.