Skip to content

Commit

Permalink
samples/vfio-mdev/mbochs: expand minor range when registering chrdev …
Browse files Browse the repository at this point in the history
…region

Actually, total amount of available minor number
for a single major is MINORMARK + 1. So expand
minor range when registering chrdev region.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
  • Loading branch information
Chengguang Xu authored and awilliam committed Feb 12, 2019
1 parent 8bcb64a commit 1635521
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions samples/vfio-mdev/mbochs.c
Original file line number Diff line number Diff line change
Expand Up @@ -1448,13 +1448,13 @@ static int __init mbochs_dev_init(void)
{
int ret = 0;

ret = alloc_chrdev_region(&mbochs_devt, 0, MINORMASK, MBOCHS_NAME);
ret = alloc_chrdev_region(&mbochs_devt, 0, MINORMASK + 1, MBOCHS_NAME);
if (ret < 0) {
pr_err("Error: failed to register mbochs_dev, err: %d\n", ret);
return ret;
}
cdev_init(&mbochs_cdev, &vd_fops);
cdev_add(&mbochs_cdev, mbochs_devt, MINORMASK);
cdev_add(&mbochs_cdev, mbochs_devt, MINORMASK + 1);
pr_info("%s: major %d\n", __func__, MAJOR(mbochs_devt));

mbochs_class = class_create(THIS_MODULE, MBOCHS_CLASS_NAME);
Expand Down Expand Up @@ -1483,7 +1483,7 @@ static int __init mbochs_dev_init(void)
class_destroy(mbochs_class);
failed1:
cdev_del(&mbochs_cdev);
unregister_chrdev_region(mbochs_devt, MINORMASK);
unregister_chrdev_region(mbochs_devt, MINORMASK + 1);
return ret;
}

Expand All @@ -1494,7 +1494,7 @@ static void __exit mbochs_dev_exit(void)

device_unregister(&mbochs_dev);
cdev_del(&mbochs_cdev);
unregister_chrdev_region(mbochs_devt, MINORMASK);
unregister_chrdev_region(mbochs_devt, MINORMASK + 1);
class_destroy(mbochs_class);
mbochs_class = NULL;
}
Expand Down

0 comments on commit 1635521

Please sign in to comment.