New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support `app=None` for `tortoise.contrib.fastapi.RegisterTortoise` #1733

Merged

abondar merged 3 commits into tortoise:develop from waketzheng:fastapi-register-without-app

Oct 13, 2024

Contributor

waketzheng commented Oct 11, 2024

Description

Make it easy for fastapi projects to init orm outside app.

Motivation and Context

Sometimes we want to query db in a interactive environment (for example in ipython)

How Has This Been Tested?

make ci

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added the changelog accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

waketzheng added 3 commits

October 11, 2024 12:01


          feat: support app=None for tortoise.contrib.fastapi.RegisterTortoise

7d30c7a


          fix example test error

9b555b3


          Compare py38

400770f

coveralls commented Oct 11, 2024

Pull Request Test Coverage Report for Build 11289129017

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.006%

Totals
Change from base Build 11271863554:	0.0%
Covered Lines:	5975
Relevant Lines:	6598

💛 - Coveralls

abondar approved these changes

View reviewed changes

abondar merged commit 101eb87 into tortoise:develop

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet