Split model consructor into from-Python and from-DB paths, leading to 15-25% speedup for large fetch operations. #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abondar Please review |
…ss the ORM. Also have a simpler, more lightweight Model constructor for select queries from database.
abondar
approved these changes
Jul 21, 2019
tortoise/queryset.py
Outdated
| @@ -517,6 +508,7 @@ def _make_query(self): | |||
| value = value.id | |||
| else: | |||
| db_field = self.model._meta.fields_db_projection[key] | |||
| # self.query._updates.append((Field(db_field), ValueWrapper(value)) | |||
There was a problem hiding this comment.
I think that line should be deleted :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this PR started off as me trying to add a post-process hook to model creation, so that we can try and have a single place to do generate pre-compute lookups.
Then I saw all the memoised properties, and thought that pre-generating this would be a good exercised of if the post-process hooks get called correctly.
It actually turns out we have 4 places where these updates can happen:
Tortoise.init(), this PR does not change this)Also split constructor into from-python and from-db so we can unblock #55
This lead to significant perf improvements in the code, especially for large selects.
ALSO:
Manipulating PyPika objects directly, 5-30% speedup for small fetches.
Not too sure about this, as it is touching some private variables. Its safe as we manually copy the PyPika object before manipulating it, but now we ALWAYS copy once, instead of for every transform.