Re-added support for __set_name__ as the Python class datamodel presc… #1084
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python class datamodel normally supports the set_name method on a class, allowing you to do:
This is a very useful feature for custom fields but the
Model
metaclass has removed this functionality. With this small patch it's re-added.Description
Add
__set_name__
support to theModel
metaclassAdd a
__set_name__
type stub toField
because mypy doesn't support__set_name__
yet: python/mypy#8057Added a test to confirm it works
Motivation and Context
I'm building a native Postgres enum field, and having the name of the field available in the class makes this a lot easier.
Instead of doing this:
I can now do:
How Has This Been Tested?
I've added a simple test to confirm that the test works. And I've run
make test
andmake style ci
Checklist: