Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor UDP server refactorings #913

Merged
merged 13 commits into from
Jun 25, 2024
Merged

Minor UDP server refactorings #913

merged 13 commits into from
Jun 25, 2024

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Jun 25, 2024 •
edited
Loading

This PR only includes some minor changes I've proposed in this PR, and some refactorings.

@josecelano josecelano force-pushed the minor-udp-server-refactorings branch from 5acbb13 to 0e3678d Compare June 25, 2024 07:04
@josecelano josecelano self-assigned this Jun 25, 2024
@josecelano josecelano added the Code Cleanup / Refactoring Tidying and Making Neat label Jun 25, 2024
@josecelano josecelano added this to the v3.0.0 milestone Jun 25, 2024
@josecelano josecelano mentioned this pull request Jun 25, 2024
Merged
@josecelano
refactor: extract const for logging targets
b4b4515 
And make it explicit the coupling between logs and `RunningServices`
type.
@josecelano josecelano requested a review from da2ce7 June 25, 2024 13:02
@josecelano
refactor: simplify UDP server receiver
35b6c84 
It only gets new UDP requests, whitout spwaning tasks to handle them.
@josecelano josecelano marked this pull request as ready for review June 25, 2024 16:54
@josecelano josecelano force-pushed the minor-udp-server-refactorings branch from efac748 to 89bb735 Compare June 25, 2024 16:55
@josecelano josecelano force-pushed the minor-udp-server-refactorings branch from 023e49d to f06976e Compare June 25, 2024 17:14
@josecelano
Copy link
Member Author

ACK f06976e

@josecelano
Copy link
Member Author

I have executed the UDP load test:

MAX

Requests out: 464927.35/second
Responses in: 418322.65/second
  - Connect responses:  207290.35
  - Announce responses: 206898.60
  - Scrape responses:   4133.71
  - Error responses:    0.00
Peers per announce response: 0.00
Announce responses per info hash:
  - p10: 1
  - p25: 1
  - p50: 1
  - p75: 1
  - p90: 2
  - p95: 3
  - p99: 105
  - p99.9: 333
  - p100: 415

MIN

Requests out: 454115.68/second
Responses in: 410225.65/second
  - Connect responses:  203099.67
  - Announce responses: 203030.45
  - Scrape responses:   4095.53
  - Error responses:    0.00
Peers per announce response: 0.00
Announce responses per info hash:
  - p10: 1
  - p25: 1
  - p50: 1
  - p75: 1
  - p90: 2
  - p95: 3
  - p99: 105
  - p99.9: 327
  - p100: 415

@josecelano josecelano merged commit eb9f997 into torrust:develop Jun 25, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees

@josecelano josecelano

Labels
Code Cleanup / Refactoring Tidying and Making Neat
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@josecelano