Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logs to Health Check API #701

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Add logs to Health Check API #701

merged 1 commit into from
Feb 19, 2024

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Feb 19, 2024 •
edited
Loading

Add logs to Health Check API. Example:

2024-02-19T11:30:21.061293933+00:00 [HEALTH CHECK API][INFO] request; method=GET uri=/health_check request_id=78933bbf-c4cf-4897-b972-4c0fd252159a
2024-02-19T11:30:21.070329733+00:00 [HEALTH CHECK API][INFO] response; latency=9 status=200 OK request_id=78933bbf-c4cf-4897-b972-4c0fd252159a

@josecelano josecelano force-pushed the 700-health-check-api-log-request-and-responses branch from 5a3d4cf to 20f8d15 Compare February 19, 2024 11:35
@josecelano josecelano added Enhancement / Feature Request Something New - Developer - Torrust Improvement Experience - Admin - Enjoyable to Install and Setup our Software labels Feb 19, 2024
@josecelano josecelano linked an issue Feb 19, 2024 that may be closed by this pull request
Health Check API: log request and responses #700
Closed
@josecelano josecelano added this to the v3.0.0 milestone Feb 19, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2024 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (db71f2a) 73.16% compared to head (e0836bd) 73.24%.

Files Patch % Lines
src/bootstrap/jobs/health_check_api.rs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #701      +/-   ##
===========================================
+ Coverage    73.16%   73.24%   +0.07%     
===========================================
  Files          143      143              
  Lines         9190     9216      +26     
===========================================
+ Hits          6724     6750      +26     
  Misses        2466     2466

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano
feat: [torrust#700] add logs to Health Check API
e0836bd 
``````
2024-02-19T11:30:21.061293933+00:00 [HEALTH CHECK API][INFO] request; method=GET uri=/health_check request_id=78933bbf-c4cf-4897-b972-4c0fd252159a
2024-02-19T11:30:21.070329733+00:00 [HEALTH CHECK API][INFO] response; latency=9 status=200 OK request_id=78933bbf-c4cf-4897-b972-4c0fd252159a
```
@josecelano josecelano force-pushed the 700-health-check-api-log-request-and-responses branch from 20f8d15 to e0836bd Compare February 19, 2024 12:20
@josecelano
Copy link
Member Author

ACK e0836bd

@josecelano josecelano merged commit d3344da into torrust:develop Feb 19, 2024
13 checks passed
@josecelano josecelano mentioned this pull request Feb 19, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
- Admin - Enjoyable to Install and Setup our Software - Developer - Torrust Improvement Experience Enhancement / Feature Request Something New
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Health Check API: log request and responses
1 participant
@josecelano