Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vairous issues in the ci. #1058

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Fix vairous issues in the ci. #1058

merged 4 commits into from
Oct 3, 2024

Conversation

da2ce7
Copy link
Contributor

@da2ce7 da2ce7 commented Oct 3, 2024 •
edited
Loading

@da2ce7 da2ce7 requested a review from a team as a code owner October 3, 2024 09:44
@josecelano josecelano linked an issue Oct 3, 2024 that may be closed by this pull request
Version 3.0.0 of all packages were not published because the workflow fails #1057
Closed
@josecelano josecelano self-assigned this Oct 3, 2024
@josecelano josecelano added Bug Incorrect Behavior Continuous Integration Workflows and Automation labels Oct 3, 2024
@josecelano josecelano added this to the v3.1.0 milestone Oct 3, 2024
@da2ce7 da2ce7 changed the title Fix workaround a tempory bug in clipply, and fix bug in release workflow Fix vairous issues in the ci. Oct 3, 2024
@josecelano josecelano mentioned this pull request Oct 3, 2024
Closed
@josecelano josecelano linked an issue Oct 3, 2024 that may be closed by this pull request
Clippy errors in nightly 1.83.0-nightly: error: unneeded return statement #1055
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.33%. Comparing base (b65f25a) to head (f95aac2).
Report is 5 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1058   +/-   ##
========================================
  Coverage    77.33%   77.33%           
========================================
  Files          178      178           
  Lines        10268    10268           
========================================
  Hits          7941     7941           
  Misses        2327     2327

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano
Copy link
Member

ACK f95aac2

@josecelano josecelano merged commit ab9f6e0 into torrust:develop Oct 3, 2024
17 checks passed
@josecelano josecelano mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josecelano josecelano josecelano approved these changes

Assignees

@josecelano josecelano

Labels
Bug Incorrect Behavior Continuous Integration Workflows and Automation
Projects
None yet
Milestone
v3.1.0
2 participants
@da2ce7 @josecelano