feat: validate SSH key paths must be absolute #226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225
Summary
This PR implements validation to ensure SSH key paths are absolute during
create environmentcommand, preventing failures later duringconfigureand other commands.Changes
is_absolute()checks for both private and public SSH key paths inSshCredentialsConfig::new()RelativePrivateKeyPath- for relative private key pathsRelativePublicKeyPath- for relative public key pathsrealpathcommand examples for fixingCARGO_MANIFEST_DIRno_runto prevent executionValidation
✅ All 1429 unit tests passing
✅ All 315 doctests passing
✅ All pre-commit checks passing
✅ Manual E2E testing confirmed:
Example Error Output
Benefits
configureand subsequent commands