Merge #725: Fix bug wrong error message for password too long error

8246f07 feat: min and max password length should be also valid (Jose Celano)
2e67cc1 fix: [#613] wrong error message for password too long error (Jose Celano)

Pull request description:

  Fix bug wrong error message for password too long error.

ACKs for top commit:
  josecelano:
    ACK 8246f07

Tree-SHA512: f65cda387d866a30be7950319ebe4f9ae7e5d6d337d1c3f842a4c890cc209247e7aab38e651dfd95f2ce94d7b00189758c7ce47325bb7a4cedb3fa55b45c55f8

src/errors.rs

@@ -55,7 +55,7 @@ pub enum ServiceError {
 
     #[display(fmt = "Password too short")]
     PasswordTooShort,
-    #[display(fmt = "Username too long")]
+    #[display(fmt = "Password too long")]
     PasswordTooLong,
     #[display(fmt = "Passwords don't match")]
     PasswordsDontMatch,

src/services/user.rs

@@ -461,11 +461,11 @@ fn validate_password_constraints(
 
     let password_length = password.len();
 
-    if password_length <= password_rules.min_password_length {
+    if password_length < password_rules.min_password_length {
         return Err(ServiceError::PasswordTooShort);
     }
 
-    if password_length >= password_rules.max_password_length {
+    if password_length > password_rules.max_password_length {
         return Err(ServiceError::PasswordTooLong);
     }