-
Notifications
You must be signed in to change notification settings - Fork 3
Bugfix of issues related to resultfield definition and processing #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an error regarding storing configs.
3 tasks
tornede
requested changes
Jul 21, 2023
Owner
tornede
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the log message changes mentioned above
4 tasks
tornede
requested changes
Jul 24, 2023
tornede
approved these changes
Jul 24, 2023
Owner
tornede
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I finished 3 issues related to resultfield definition and processing that caused problems for users.
Motivation and Context
PyExperimenterwith invalid configuration files have terminated with an error, without giving further information about the issue (Improve handling of configuration file and their invalidity #139).PyExperimenterterminated with an error if a given resultfield was not defined in the configuration file and therefore was not covered in the database. Unfortunately, no information was given which field caused the problem (Improve processing information of ResultProcessor #140).Type Of Changes
How has This Been Tested?
Executed testcases, added minor testcases and executed examples. Also double checked that the checks for the existence of result/logtable columns work, by adapting
own_functionsin the notebookAll tests have been executed.
Does this Close/Impact Existing Issues?
Checklist
developbranch.mysqlas provider.CHANGELOG.rst.