Skip to content

Conversation

@LukasFehring
Copy link
Collaborator

@LukasFehring LukasFehring commented Jul 21, 2023

Description

I finished 3 issues related to resultfield definition and processing that caused problems for users.

Motivation and Context

Type Of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has This Been Tested?

  • Database provider: MySQL and SQLite
  • Python version: 3.9.12
  • Operating System: Ubuntu, MacOSX

Executed testcases, added minor testcases and executed examples. Also double checked that the checks for the existence of result/logtable columns work, by adapting own_functions in the notebook

All tests have been executed.

Does this Close/Impact Existing Issues?

Checklist

  • My change is based on the latest stage of the develop branch.
  • My change required a change of the documentation, which has been done.
  • I checked that the documentation can be build, visualizes everything as expected, and does not contain any warnings.
  • I have added/adapted tests to cover my changes.
  • The tests can be executed successfully.
  • The notebooks can be executed successfully.
  • The notebooks can be executed with mysql as provider.
  • I have added a description of the changes to CHANGELOG.rst.

@LukasFehring LukasFehring linked an issue Jul 21, 2023 that may be closed by this pull request
@LukasFehring LukasFehring changed the title Fix issues Close three issues Jul 21, 2023
@LukasFehring LukasFehring linked an issue Jul 21, 2023 that may be closed by this pull request
3 tasks
@tornede tornede self-requested a review July 21, 2023 12:43
Copy link
Owner

@tornede tornede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the log message changes mentioned above

@LukasFehring LukasFehring changed the title Close three issues [DRAFT] Close three issues Jul 21, 2023
@LukasFehring LukasFehring linked an issue Jul 21, 2023 that may be closed by this pull request
4 tasks
Copy link
Owner

@tornede tornede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tornede tornede changed the title [DRAFT] Close three issues Bugfix of issues related to resultfield definition and processing Jul 24, 2023
@tornede tornede merged commit 34e1c6d into develop Jul 24, 2023
@tornede tornede deleted the fix-issues branch July 24, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants