-
Notifications
You must be signed in to change notification settings - Fork 3
Update version to 1.2.0 #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated pyproject.toml to support Python >= 3.9 * Updated tests to be performed for Python >= 3.9
* Change row identification in ResultProcessor to ExperimentID instead of checking keyfields
* Change row identification in ResultProcessor. Instead of checking keyfields the experiment_id is utilized * Change used mysql-connector implementation to c * Use prepared statement to escape values - delete old escaping functionality - add utils.get_current_time to avoid duplicated code - database_connector.update_database now takes different parameters - reformatting of test_run_sqlite_experiments - add testcase to check if errors get written into the database correct * Make tests Windows compatible
* Fix and slight modification in test workflow. * Remove unused parameters * Add windows to settings.json * Update poetry to include joblib * Use joblib for multiprocessing. Remove old dependencies, notebooks and update testcases --------- Co-authored-by: Lukas Fehring <lukasfehring@gmail.com> Co-authored-by: Tanja Tornede <t.tornede@ai.uni-hannover.de>
Co-authored-by: Lukas Fehring <lukasfehring@gmail.com>
* Added Logtable functionality, example notebook and documentation * Reworked how tables are created in general * Reworked large part of usage documentation * Added timestamps to result tables * Unified timestamp handling * Reorder functionality in utils.py * Added freezegun to poetry develop environment for easier testing * Added missing path checks of examples --------- Co-authored-by: Tanja Tornede <t.tornede@ai.uni-hannover.de> Co-authored-by: Alexander Tornede <a.tornede@ai.uni-hannover.de>
* Update version and changelog * Updated author email address * Removed duplicated line of code * Remove unnecessary "the" in document title --------- Co-authored-by: Lukas Fehring <lukas.ferhing@stud.uni-hannover.de>
alexandertornede
requested changes
Apr 4, 2023
Collaborator
alexandertornede
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the comments on the docs (missing dots), it LGTM.
alexandertornede
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.