fix bug setting options programatically #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I was actually surprised to learn that string options are actually type unicode - I guess I've only ever used ascii values in python2 so I never noticed. This looks like a good change. |
bdarnell
added a commit
that referenced
this pull request
May 7, 2012
fix bug setting options programatically
Rudd-O
pushed a commit
to Rudd-O/tornado
that referenced
this pull request
Jun 27, 2013
fix bug setting options programatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you set an option in code:
options.my_option = value
this would overwrite the _Options attribute with a non _Option value. This would break subsequent retrieval of the option. This code change adds a parallel setattr to the existing getattr.
I also fixed a bug with the root type - 'str' should have been 'basesting' - since we return a _unicode() converted string - which fails when you try to set the value back again.