make commandline args override config file args when multiple=True #484
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make commandline args override config file args when multiple=True instead of appending to config file args
|
Yeah, it's a little weird when you combine files and flags in this way. On the other hand, the current behavior lets you say "--x=foo --x=bar" and then options.x==["foo", "bar"]. This doesn't appear to have been documented, but I think it was intentional. However, since there is no way to disable the comma-splitting, the ability to specify options multiple times is probably more trouble than its worth. |
bdarnell
added a commit
that referenced
this pull request
May 7, 2012
make commandline args override config file args when multiple=True
Rudd-O
pushed a commit
to Rudd-O/tornado
that referenced
this pull request
Jun 27, 2013
make commandline args override config file args when multiple=True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make commandline args override config file args when multiple=True instead of appending to config file args
Currently, when you have an option x where multiple=True, and you have x = ['hi'] in the config file, and you pass --x=bye in the commandline, options.x will be set to ['hi', 'bye'].
I think it's weird and inconsistent to have commandline args append to config file args when multiple=True, when they override config file args when multiple=False.