web: Cookie updates #3224
Merged
web: Cookie updates #3224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This more precisely states the kind of security that is provided, and avoids confusion with the use of the word "secure" as a standard cookie attribute and prefix.
Multiple arguments needed special cases anyway, so it's better to just be explicit about what's supported. set_signed_cookie still uses kwarg forwarding since we don't need to worry about the special cases at this level and using explicit arguments would involve duplicating defaults in multiple places.
In some cases it is now required to pass matching values for samesite and secure as when the cookie was set. clear_all_cookies is now deprecated because the name of a cookie is no longer reliably sufficient to clear it. Fixes tornadoweb#2911
bdarnell
added a commit
to bdarnell/tornado
that referenced
this pull request
Apr 21, 2023
This was an unintended feature that got broken in tornadoweb#3224. Bring it back for now but deprecate it for future cleanup.
bdarnell
added a commit
to bdarnell/tornado
that referenced
this pull request
Apr 21, 2023
This was an unintended feature that got broken in tornadoweb#3224. Bring it back for now but deprecate it for future cleanup. Fixes tornadoweb#3252
bdarnell
added a commit
to bdarnell/tornado
that referenced
this pull request
Apr 21, 2023
This was an unintended feature that got broken in tornadoweb#3224. Bring it back for now but deprecate it for future cleanup. Fixes tornadoweb#3252
bdarnell
added a commit
to bdarnell/tornado
that referenced
this pull request
Apr 21, 2023
This was an unintended feature that got broken in tornadoweb#3224. Bring it back for now but deprecate it for future cleanup. Fixes tornadoweb#3252
bdarnell
added a commit
to bdarnell/tornado
that referenced
this pull request
Apr 21, 2023
This was an unintended feature that got broken in tornadoweb#3224. Bring it back for now but deprecate it for future cleanup. Fixes tornadoweb#3252
bdarnell
added a commit
to bdarnell/tornado
that referenced
this pull request
Apr 21, 2023
This was an unintended feature that got broken in tornadoweb#3224. Bring it back for now but deprecate it for future cleanup. Fixes tornadoweb#3252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various updates to cookie APIs