Support multiple saved custom background layers by tordans · Pull Request #5 · tordans/iD

tordans · 2026-08-02T05:17:24Z

Testing

x

Note to self: Edit redirect URL at https://www.openstreetmap.org/oauth2/applications/12061/edit

Summary

iD can now remember more than one custom background imagery layer. If you regularly switch between a local WMS server, a specialty tile set, and OpenStreetMap tiles, you no longer have to re-enter the URL each time — save each one, give it an optional name, and pick it from the Background list like any other layer.

What you get:

Several custom backgrounds at once — add as many tile URL templates as you need; each appears as its own entry in the Background pane.
Optional names — label layers (e.g. “City orthophoto 2024”) so long URLs don’t clutter the list.
Edit and delete — change a saved URL or remove a layer you no longer need, with a confirmation before delete.
Quick switching — custom layers stay at the top of the background list and work with the existing background toggle.
Shareable links — #background=custom:<url> still works: the URL is added to your saved list (if new) and selected.
Seamless upgrade — an existing single custom background from older iD versions is migrated automatically on first use.

Reimplements #8874.

Test plan

npm test — lint, build, typecheck, and all specs pass locally
Add two custom backgrounds with different URLs; confirm both appear in the list and can be selected
Edit a saved custom background (name and/or URL); confirm the map updates and the entry stays stable
Delete a custom background; confirm it is removed and the map falls back to None when that layer was active
Open iD with #background=custom:<url>; confirm the URL is saved and selected
Upgrade from a profile with only the legacy single custom template; confirm it migrates to one saved entry

Made with Cursor

this is a separate commit to avoid destroying the git blame

netlify · 2026-08-02T05:17:28Z

✅ Deploy Preview for tordans-id-experiments ready!

Name	Link
🔨 Latest commit	`8f1f8d5`
🔍 Latest deploy log	https://app.netlify.com/projects/tordans-id-experiments/deploys/6a778b0260eba40008710155
😎 Deploy Preview	https://deploy-preview-5--tordans-id-experiments.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

cursor

Stale comment

Left a non-blocking comment: Cursor Bugbot finished as skipping and reported unresolved findings (including a medium-severity legacy custom-id toggle issue), so this run is not approving. Requesting human reviewers for the custom-background changes.

_{Sent by Cursor Approval Agent: Dependabot Review and Auto Merge}

cursor

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit ebc39fb. Configure here.}

cursor

Stale comment

Left a non-blocking comment: Cursor Bugbot finished as skipping and reported an unresolved medium finding (deduped custom background ignores the new name), so this run is not approving. Requesting human reviewers for the custom-background changes.

_{Sent by Cursor Approval Agent: Dependabot Review and Auto Merge}

allows to find presets by their raw tags in `addTags` as well

…map#12677) Bumps the types group with 1 update: [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node). Updates `@types/node` from 26.1.1 to 26.1.2 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 26.1.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: types ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…2653)

…peed-single-digit Delete the unused lane parsing code

* hide "add tag" row * fix rounded borders at corners * drop unused css class * add missing padding in tag editor section * remove line between heading and properties list

…elds tags fixes openstreetmap#12082, closes openstreetmap#12102

with full (raw) tag value and description if available Co-authored-by: Martin Raifer <martin@raifer.tech>

…ap#12652)

…ap#12685) `options` is only set from `field.options`, so it stays undefined for check fields without an explicit list (e.g. `backrest`). Calling `options.includes()` then threw while rendering the entity editor, which aborted mode select before it applied the mode class, leaving the map without select cursors and the raw tag editor showing the previous feature. Compare against `values`, which always falls back to yes/no. Co-authored-by: Cursor <cursoragent@cursor.com>

Bumps [jsdom](https://github.com/jsdom/jsdom) from 30.0.0 to 30.0.1. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Commits](jsdom/jsdom@v30.0.0...v30.0.1) --- updated-dependencies: - dependency-name: jsdom dependency-version: 30.0.1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

The active list/text toggle does nothing when clicked again, so a hand cursor is misleading. Co-authored-by: Cursor <cursoragent@cursor.com>

Generalize the heading-line icon button classes so other disclosures can reuse the same chrome without a second CSS path. Co-authored-by: Cursor <cursoragent@cursor.com>

The star is informational (tooltip only), so show the question cursor instead of a text I-beam. Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

Replaces the single custom background with a saved list: add/edit/delete rows, optional names, cleaned URL templates, collapsible WMS/TMS help, and `#background=custom:<url>` / legacy `#background=custom` hash support. Co-authored-by: Cursor <cursoragent@cursor.com>

cursor · 2026-08-08T16:16:21Z

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_0dce5adb-a904-464f-b870-bf232fe33ed1)

cursor

Stale comment

Left a non-blocking comment: Cursor Bugbot finished as skipping on this synchronize, so this run is not approving. Assigned human reviewers for the custom-background changes.

_{Sent by Cursor Approval Agent: Dependabot Review and Auto Merge}

Co-authored-by: Cursor <cursoragent@cursor.com>

cursor · 2026-08-08T18:55:58Z

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_3b84d9b6-8113-45c3-8b1d-967f35fdfd85)

cursor

Stale comment

Left a non-blocking comment: Cursor Bugbot finished as skipping on this synchronize, so this run is not approving. Assigning human reviewers for the custom-background changes.

_{Sent by Cursor Approval Agent: Dependabot Review and Auto Merge}

Place add/view controls in the summary and hide them with :not(:open), removing the negative-margin layout hack. Co-authored-by: Cursor <cursoragent@cursor.com>

Reuse the shared 200px tooltip width; scrollContainer and word-break already keep long URLs inside the pane. Co-authored-by: Cursor <cursoragent@cursor.com>

Keep this PR focused on custom backgrounds; leave that validation string bug for a separate fix. Co-authored-by: Cursor <cursoragent@cursor.com>

The optional label is enough; an example string is unnecessary. Co-authored-by: Cursor <cursoragent@cursor.com>

Avoid a noise-only const/let rewrite in the PR diff. Co-authored-by: Cursor <cursoragent@cursor.com>

TypeScript can type reads as string|null and writes as boolean, so callers no longer need a local cast. Co-authored-by: Cursor <cursoragent@cursor.com>

Run template + last-used migration only when needed, clear the old key, and stop writing an empty list on fresh installs. Co-authored-by: Cursor <cursoragent@cursor.com>

Drop the global hyphenation rules and stop wiring scrollContainer onto ordinary background-list tooltips. Co-authored-by: Cursor <cursoragent@cursor.com>

Pass the entry via d3 selection.call instead of a forEntry helper, and drop unnecessary type casts. Co-authored-by: Cursor <cursoragent@cursor.com>

Type uiModal/uiConfirm and utilNoAuto at the source so the settings modal no longer needs as-any workarounds. Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

Drop the thin setPref/getPref wrappers now that prefs is typed. Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

Apply selected/hover/active styles to label and button cells so custom edit controls don't need a background-pane override. Co-authored-by: Cursor <cursoragent@cursor.com>

Put the example URL under the template field, drop the help-icon column, and fix extra gaps from inline textarea baseline and disclosure line-height. Co-authored-by: Cursor <cursoragent@cursor.com>

cursor · 2026-08-08T20:01:17Z

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_ed478cd3-90a7-42fa-b295-61240e5172a4)

cursor

Left a non-blocking comment: Cursor Bugbot finished as skipping on this synchronize, so this run is not approving. Assigning human reviewers for the custom-background changes.

_{Sent by Cursor Approval Agent: Dependabot Review and Auto Merge}

tordans · 2026-08-09T04:08:58Z

This is now on openstreetmap#12703

yorty001 and others added 5 commits July 1, 2026 15:40

Fix tag search to also check addTags when searching by key=value

923a5aa

Add test for addTags tag search

36208e9

fix indent

8a63600

rename files

f169463

this is a separate commit to avoid destroying the git blame

migrate actions to typescript (part 6)

48e4a94

cursor Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread data/core.yaml

tordans force-pushed the multiple-custom-backgrounds branch from 8fc9c27 to 0f19c10 Compare August 2, 2026 05:22

cursor Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread modules/renderer/custom_backgrounds.ts Outdated

cursor Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread modules/renderer/background.js

cursor Bot reviewed Aug 2, 2026

View reviewed changes

tyrasd and others added 18 commits August 4, 2026 12:21

Merge pull request openstreetmap#12616 from matkoniecz/add_tags_search

51ecbb0

allows to find presets by their raw tags in `addTags` as well

update label (renamed to "considering/unclear")

8d4f17e

migrate presets and fields to typescript (openstreetmap#12639)

cf7aa56

migrate preset category and collection to typescript (openstreetmap#1…

98420e9

…2653)

var -> const

140b272

migrate actions to typescript (part 6) (openstreetmap#12640)

1b1c218

Merge pull request openstreetmap#12664 from wantaekchoi/fix/parsemaxs…

a9d3473

…peed-single-digit Delete the unused lane parsing code

delete dead code from preset manager (openstreetmap#12655)

3776d54

migrate validators to typescript (part 1) (openstreetmap#12641)

4f0ad99

migrate coreContext to typescript (openstreetmap#12642)

5aba48b

fix styling of custom map data "tag" list

d143a2d

* hide "add tag" row * fix rounded borders at corners * drop unused css class * add missing padding in tag editor section * remove line between heading and properties list

render (temporary) placeholder options for unknown values of radio-fi…

58b22fd

…elds tags fixes openstreetmap#12082, closes openstreetmap#12102

show tooltips for radio and check fields

cb414f5

with full (raw) tag value and description if available Co-authored-by: Martin Raifer <martin@raifer.tech>

update assets

d083400

fix minor bugs with the country and language input field (openstreetm…

b8543e4

…ap#12652)

tordans and others added 5 commits August 8, 2026 18:14

Use default cursor on the selected raw-tag view button

c26ec47

The active list/text toggle does nothing when clicked again, so a hand cursor is misleading. Co-authored-by: Cursor <cursoragent@cursor.com>

Rename raw-tag-option to disclosure-header-option

ba90a0a

Generalize the heading-line icon button classes so other disclosures can reuse the same chrome without a second CSS path. Co-authored-by: Cursor <cursoragent@cursor.com>

Use help cursor on the best-imagery star

83f2868

The star is informational (tooltip only), so show the question cursor instead of a text I-beam. Co-authored-by: Cursor <cursoragent@cursor.com>

Improve wrapping of long unbroken strings in tooltips

9c0d524

Co-authored-by: Cursor <cursoragent@cursor.com>

tordans force-pushed the multiple-custom-backgrounds branch from ebc39fb to eb4208f Compare August 8, 2026 16:16

cursor Bot reviewed Aug 8, 2026

View reviewed changes

Remove undocumented bare #background=custom hash handling

894d561

Co-authored-by: Cursor <cursoragent@cursor.com>

cursor Bot reviewed Aug 8, 2026

View reviewed changes

tordans and others added 15 commits August 8, 2026 21:07

Render disclosure header options in the summary row

b8c3593

Place add/view controls in the summary and hide them with :not(:open), removing the negative-margin layout hack. Co-authored-by: Cursor <cursoragent@cursor.com>

Drop special max-width for code tooltips in the map pane

552637c

Reuse the shared 200px tooltip width; scrollContainer and word-break already keep long URLs inside the pane. Co-authored-by: Cursor <cursoragent@cursor.com>

Revert unrelated convert-to-area annotation changes

c92f9c2

Keep this PR focused on custom backgrounds; leave that validation string bug for a separate fix. Co-authored-by: Cursor <cursoragent@cursor.com>

Remove placeholder from the custom background name field

840c5e4

The optional label is enough; an example string is unnecessary. Co-authored-by: Cursor <cursoragent@cursor.com>

Keep original var style in unchanged Custom.imageryUsed code

60162e3

Avoid a noise-only const/let rewrite in the PR diff. Co-authored-by: Cursor <cursoragent@cursor.com>

Document prefs get/set return types with JSDoc overloads

bc574f3

TypeScript can type reads as string|null and writes as boolean, so callers no longer need a local cast. Co-authored-by: Cursor <cursoragent@cursor.com>

Consolidate legacy custom-background migration into one path

c59f42f

Run template + last-used migration only when needed, clear the old key, and stop writing an empty list on fresh installs. Co-authored-by: Cursor <cursoragent@cursor.com>

Narrow tooltip changes to custom URL rows only

bda701a

Drop the global hyphenation rules and stop wiring scrollContainer onto ordinary background-list tooltips. Co-authored-by: Cursor <cursoragent@cursor.com>

Simplify custom background settings open API

a2a197c

Pass the entry via d3 selection.call instead of a forEntry helper, and drop unnecessary type casts. Co-authored-by: Cursor <cursoragent@cursor.com>

Remove type casts from custom background settings

05d08ac

Type uiModal/uiConfirm and utilNoAuto at the source so the settings modal no longer needs as-any workarounds. Co-authored-by: Cursor <cursoragent@cursor.com>

Remove explanatory comment from modal shade click handler

97ea75d

Co-authored-by: Cursor <cursoragent@cursor.com>

Call prefs directly in background custom tests

869b04f

Drop the thin setPref/getPref wrappers now that prefs is typed. Co-authored-by: Cursor <cursoragent@cursor.com>

Note that custom backgrounds from the URL are stored in localStorage

428338e

Co-authored-by: Cursor <cursoragent@cursor.com>

Highlight layer-list cells instead of whole rows

8e14db1

Apply selected/hover/active styles to label and button cells so custom edit controls don't need a background-pane override. Co-authored-by: Cursor <cursoragent@cursor.com>

Tighten custom background settings help layout and spacing

8f1f8d5

Put the example URL under the template field, drop the help-icon column, and fix extra gaps from inline textarea baseline and disclosure line-height. Co-authored-by: Cursor <cursoragent@cursor.com>

cursor Bot reviewed Aug 8, 2026

View reviewed changes

tordans closed this Aug 9, 2026

Navigation Menu

Support multiple saved custom background layers - #5

Support multiple saved custom background layers#5
tordans wants to merge 57 commits into
developfrom
multiple-custom-backgrounds

tordans commented Aug 2, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Aug 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment •

edited

Loading

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

cursor Bot left a comment •

edited

Loading

Uh oh!

cursor Bot commented Aug 8, 2026

Uh oh!

cursor Bot left a comment •

edited

Loading

Uh oh!

cursor Bot commented Aug 8, 2026

Uh oh!

cursor Bot left a comment •

edited

Loading

Uh oh!

cursor Bot commented Aug 8, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

tordans commented Aug 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

tordans commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Summary

Test plan

Uh oh!

netlify Bot commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for tordans-id-experiments ready!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor Bot commented Aug 8, 2026

Bugbot couldn't run - usage limit reached

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor Bot commented Aug 8, 2026

Bugbot couldn't run - usage limit reached

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor Bot commented Aug 8, 2026

Bugbot couldn't run - usage limit reached

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

tordans commented Aug 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tordans commented Aug 2, 2026 •

edited

Loading

netlify Bot commented Aug 2, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading