Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added versioneer and updated setuptools building #291

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

stefdoerr
Copy link
Collaborator

No description provided.

@stefdoerr stefdoerr self-assigned this Feb 23, 2024
pyproject.toml Outdated Show resolved Hide resolved
@stefdoerr
Copy link
Collaborator Author

Done I think. Tests pass, so we should be fine

@RaulPPelaez
Copy link
Collaborator

Looking at the versioneer README it seems like one of the steps requires running "versioneer install --no-vendor".
I understand this is what generated the big _version.py file and it is not required to run it again? (unless to update versioneer I guess).
Also, does this add versioneer as a dependency?

@stefdoerr
Copy link
Collaborator Author

Yes, although I've stopped using that command because it touches too much stuff which I don't want it to. So I usually just copy the _version.py from a previous project, modifying the package name in it and do the rest manually. I don't like sneaky executables modifying my codebase

@RaulPPelaez
Copy link
Collaborator

It also appears that versioneer is just a build time dependency, which is nice.

@stefdoerr
Copy link
Collaborator Author

Yes, since we ship that big _version.py file you don't need to add it as a runtime dep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants