R1-269: Scholarships - Showing in programme pages #1106
+64
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gible programme for a scholarship shnippet
patrickcuagan
force-pushed
the
feature/269-scholarships-in-programme-pages
branch
from
56f0784 to
7510efb
Compare
neilbulloch
requested changes
Nov 3, 2025
Comment on lines
1118
to
1137
| if self.scholarship_set.exists(): | ||
| return [ | ||
| { | ||
| "value": { | ||
| "heading": s.title, | ||
| "introduction": s.summary, | ||
| "eligible_programmes": ", ".join( | ||
| str(x) for x in s.eligable_programmes.live() | ||
| ), | ||
| "funding_categories": ", ".join( | ||
| x.title for x in s.funding_categories.all() | ||
| ), | ||
| "fee_statuses": ", ".join( | ||
| x.title for x in s.fee_statuses.all() | ||
| ), | ||
| "value": s.value, | ||
| } | ||
| } | ||
| for s in self.scholarship_set.all() | ||
| ] |
There was a problem hiding this comment.
Issue: I think there is N+1 problem here.
If a programme has 10 scholarships, you're making:
1 query to get scholarships
10 queries for eligible_programmes
10 queries for funding_categories
10 queries for fee_statuses
There was a problem hiding this comment.
Ah thanks. Good catch! I've updated this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://torchbox.atlassian.net/browse/R1-269
This PR implements pulling in of scholarship snippets to programme pages.