Skip to content

Conversation

@patrickcuagan
Copy link
Collaborator

@patrickcuagan patrickcuagan commented Oct 28, 2025

Ticket: https://torchbox.atlassian.net/browse/R1-213

This PR does a template audit of breakages that could happen if a referenced page is deleted. What we checked are:

  • Usage of page.<attribute> e.g. page.specific, page.title, etc.
  • Usage of {% pageurl <page> %}.

We tested by:

  • In any page type that has a page chooser, reference a page to a field that has a page chooser.
  • Delete that page.
  • View the page to verify that the page can still be viewed.

@patrickcuagan patrickcuagan force-pushed the feature/213-template-code-audit branch from 0c78464 to ae5fcb3 Compare October 28, 2025 02:58
@patrickcuagan patrickcuagan force-pushed the feature/213-template-code-audit branch from ae5fcb3 to 3d5e7a6 Compare October 28, 2025 03:04
@neilbulloch
Copy link
Collaborator

Hey @patrickcuagan this looks good to me code wise. It's hard to understand the full impact throughout the codebase, but the changes look sensible to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants