Skip to content

fix: make it work for django5.0 #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

llPekoll
Copy link
Contributor

@llPekoll llPekoll commented Dec 16, 2023

Fixes #235

Comment on lines 5 to +6
py{38,39,310,311}-dj42
py{38,39,310,311}-dj50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
py{38,39,310,311}-dj42
py{38,39,310,311}-dj50
py{38,39,310,311,12}-dj42
py{310,311,12}-dj50

https://docs.djangoproject.com/en/dev/faq/install/#what-python-version-can-i-use-with-django

@cclauss
Copy link
Contributor

cclauss commented Jan 9, 2024

CI / test failure was fixed by upgrading flake8 in #237 (merged). If you rebase this pull request, that test should pass.

@alxbridge
Copy link
Contributor

Closing in favour of #241 - thanks for the original PR @llPekoll !

@alxbridge alxbridge closed this Jan 16, 2024
cclauss added a commit to cclauss/django-pattern-library that referenced this pull request Jan 16, 2024
cclauss added a commit to cclauss/django-pattern-library that referenced this pull request Jan 16, 2024
zerolab pushed a commit that referenced this pull request Jan 17, 2024
* GitHub Actions: Add Python 3.12 to the testing
As discussed at #236 (review)
* tox.ini: Add py312
* Stop testing Django v4.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Django 5.0
3 participants