Skip to content

Add Django 4.2 to the testing matrix #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2023
Merged

Add Django 4.2 to the testing matrix #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,19 @@ jobs:
- python: "3.7"
toxenv: py37-dj32
- python: "3.8"
toxenv: py38-dj32,py38-dj40,py38-dj41
toxenv: py38-dj32,py38-dj40,py38-dj41,py38-dj42
- python: "3.9"
toxenv: py39-dj32,py39-dj40,py39-dj41
toxenv: py39-dj32,py39-dj40,py39-dj41,py39-dj42
- python: "3.10"
# Skip testing Django 4.0, already tested in previous workflow job.
toxenv: py310-dj32,py310-dj41,py310-djmain
toxenv: py310-dj32,py310-dj41,py310-dj42,py310-djmain
- python: "3.11"
toxenv: py311-dj41,py311-dj42,py311-djmain
# Tentative support for next Python pre-release. For the correct specifier,
# Check: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json.
- python: "3.11.0-beta.2"
toxenv: py311-dj41
# when django supports py312, then uncomment this
# - python: "3.12.0-alpha.6"
# toxenv: py312-dj41
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v3
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Changelog

## [Unreleased]

- Tentative support for Django 4.2 ([#212](https://github.com/torchbox/django-pattern-library/issues/212),[#220](https://github.com/torchbox/django-pattern-library/pull/220)).
- Disable pointer events on menu chevron to allow clicks ([#202](https://github.com/torchbox/django-pattern-library/issues/202), [#205](https://github.com/torchbox/django-pattern-library/pull/205))

## [1.0.0](https://github.com/torchbox/django-pattern-library/releases/tag/v1.0.0) - 2022-06-10
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ classifiers = [
"Framework :: Django :: 3.2",
"Framework :: Django :: 4.0",
"Framework :: Django :: 4.1",
"Framework :: Django :: 4.2",
]
packages = [
{ include = "pattern_library" },
Expand Down
12 changes: 10 additions & 2 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,17 @@
[tox]
envlist = py{37,38,39,310,311}-dj{32,40,41,main}, lint
envlist =
py{37,38,39,310}-dj32
py{38,39,310,311}-dj40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a good time to drop Django 4.0 from the matrix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I’ll do that and Python 3.7 separately.

py{38,39,310,311}-dj41
py{38,39,310,311}-dj42
py{310,311}-djmain
lint
skipsdist = true

[testenv]
whitelist_externals =
allowlist_externals =
poetry
./tox_install.sh
install_command =
./tox_install.sh {packages}
commands =
Expand All @@ -17,6 +24,7 @@ deps =
; Use pre-releases until stable releases are available.
; dj42: Django==4.2a1
; dj42: Django>=4.2,<4.3
dj42: Django==4.2rc1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dj42: Django==4.2rc1
dj42: Django>=4.2,<4.3

djmain: https://github.com/django/django/archive/main.zip

[testenv:lint]
Expand Down