Use custom range in HardTanh and mask it as Clamp #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made a couple of comments, the rest looks good, seems quite useful |
jhjin
force-pushed
the
clamp
branch
2 times, most recently
from
3d7bd60 to
89a1970
Compare
|
@szagoruyko Thanks for your time. I updated the code to use the consistent ordering in arguments and considered backward compatibility. The same as for cunn. |
allows HardTanh to use a custom interval for linear region when min/max values are specified in declaration. Thus its implementation can be shared with new Clamp function.
soumith
added a commit
that referenced
this pull request
Oct 7, 2015
Use custom range in HardTanh and mask it as Clamp
|
Thanks a lot Jonghoon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows HardTanh to use a custom interval for linear region when min/max values
are specified in declaration. Thus its implementation can be shared with new
Clamp function.