Skip to content

Comments

Fix sub and div for integer types#462

Merged
soumith merged 1 commit intotorch:masterfrom
apaszke:sub_div_fix
Aug 11, 2016
Merged

Fix sub and div for integer types#462
soumith merged 1 commit intotorch:masterfrom
apaszke:sub_div_fix

Conversation

@apaszke
Copy link
Contributor

@apaszke apaszke commented Aug 11, 2016

subtract != negate + add for unsigned types
divide != inverse + multiply for integer types

@soumith soumith merged commit 5511782 into torch:master Aug 11, 2016
@soumith
Copy link
Member

soumith commented Aug 11, 2016

Thanks!

@wickedfoo
Copy link
Contributor

wickedfoo commented Aug 11, 2016

lgtm

soumith added a commit that referenced this pull request Aug 12, 2016
@soumith
fix typo from #462
19310cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apaszke @soumith @wickedfoo