Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAT-433] Measure Field Data in Google Analytics #551

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

filipechagas
Copy link
Contributor

Description

Send Core Web Vitals information to Google Analytics

How to test

  • Edit docker-compose-dev.yml and add a valid GOOGLE_ANALYTICS_UID
  • docker-compose -f docker-compose-dev.yml up go to any page and open the Google Tag Assistant and enable tracking from the extension
  • Refresh the page, and you should see LCP in the list of events
  • Click anywhere on the page and you should see FID also emitted as an event
  • Go to another tab and come back to the page and you should see CLS emitted as a events (emitted on visibilityHidden)

@filipechagas filipechagas requested a review from a team September 13, 2021 17:43
@konstrybakov
Copy link
Contributor

Screenshot 2021-09-14 at 07 53 34

This is in the compiled JS file. I haven't work with gitignore but I think if we commit the built js file, then we need to rebuild it to remove this alert!

Copy link
Contributor

@konstrybakov konstrybakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that it looks good! But needs regenerating the main.js

Thank you Filipe

@filipechagas
Copy link
Contributor Author

Screenshot 2021-09-14 at 07 53 34

This is in the compiled JS file. I haven't work with gitignore but I think if we commit the built js file, then we need to rebuild it to remove this alert!

🤦 Gitignore doesn't automatically compiles the assets and I completely forgot to commit the compiled file after I removed the alert. Thanks for spotting that!

@filipechagas filipechagas merged commit 8443122 into master Sep 14, 2021
@filipechagas filipechagas deleted the SAT-433-measure-field-data-in-google-analytics branch September 14, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants