Make default index scope cleanup behavior configurable #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of warning, you can completely ignore cases when the scope include order/offset/limit or you can raise an exception instead.
|
@toptal-anvil ping reviewers |
AlexVPopov
approved these changes
Jan 29, 2024
konalegi
reviewed
Jan 29, 2024
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| ### New Features | |||
|
|
|||
| * [#925](https://github.com/toptal/chewy/pull/925): Add configuration option for default scope cleanup behavior. ([@barthez][]) | |||
barthez
force-pushed
the
import-scope-cleanup-behavior
branch
from
2ec9bde
to
2307131
Compare
barthez
force-pushed
the
import-scope-cleanup-behavior
branch
from
2307131
to
d516fa4
Compare
|
@toptal-anvil ping reviewers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of warning, you can completely ignore cases when the scope include order/offset/limit or you can raise an exception instead.
This change is actually a performance improvment. Avoiding
arelcalls to identify it default scope has order/offset/limit is time consuming and we don't need to verify it every time we boot.Additional option of raising an exception might be useful for tests to prevent defining scopes with ordering or pagination.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).