Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip journal creation on import #888

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

konalegi
Copy link
Contributor

@konalegi konalegi commented Jul 2, 2023

Adds option to disable journal creation on import. Since it's executed on each import that might save a lot of bandwidth, for our app it's around 20% of all requests.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

@konalegi konalegi marked this pull request as ready for review July 5, 2023 10:48
@konalegi konalegi marked this pull request as draft July 5, 2023 10:48
@konalegi konalegi marked this pull request as ready for review July 5, 2023 11:16
@konalegi konalegi requested a review from a team July 5, 2023 11:16
@konalegi
Copy link
Contributor Author

konalegi commented Jul 5, 2023

@toptal-anvil ping reviewers

@konalegi konalegi merged commit f77e9dc into master Jul 5, 2023
@konalegi konalegi deleted the option-to-skip-journal-creation-on-import branch July 5, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants