Fix return value of subscribed_task_stats

[fabiormoura]

The method subscribed_task_stats wraps almost all methods in RakeHelper but it has a bug.

For instance, the upgrade method in the same module is supposed to return a list of changed indexes in

chewy/lib/chewy/rake_helper.rb

Lines 65 to 85 in 7d56754

	subscribed_task_stats(output) do
	indexes = indexes_from(only: only, except: except)
	changed_indexes = indexes.select do |index|
	index.specification.changed?
	end
	if changed_indexes.present?
	indexes.each do |index|
	if changed_indexes.include?(index)
	reset_one(index, output, parallel: parallel)
	else
	output.puts "Skipping #{index}, the specification didn't change"
	end
	end
	else
	output.puts 'No index specification was changed'
	end
	changed_indexes
	end

However, the wrapping method isn't returning to the caller the value of changed_indexes. Instead, it returns the result of the method output.puts which is nil.

I'm simply moving output.puts to be called within ensure so the output of the method correctly returns the result of:

ActiveSupport::Notifications.subscribed(Chewy::RakeHelper::JOURNAL_CALLBACK.curry[output], "apply_journal.chewy") do
    ActiveSupport::Notifications.subscribed(Chewy::RakeHelper::IMPORT_CALLBACK.curry[output], "import_objects.chewy", &block)
end

that would resolve to the correct value in the end when &block is evaluated.

---

Before submitting the PR make sure the following are checked:

• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

[konalegi]

hey, @fabiormoura thanks for the fix, PR looks good, but, could you please provide a spec for the subscribed_task_stats method? Thanks!

[konalegi]

Also, please provide a changelog entry, so that will be easier to generate a release (example)

[fabiormoura]

Also, please provide a changelog entry, so that will be easier to generate a release (example)

Thanks for the suggestions @konalegi. I made the changes which have been amended.

[konalegi]

I would say it's a bug fix, rather than a new feature :)

[fabiormoura]

It was because I haven't noticed there was a specific section in this file for bug fixes but thanks for approving the PR with this small mistake.

[fabiormoura]

this has been resolved.

[konalegi]

@fabiormoura could you please fix rubocop offenses as well? Thanks

[fabiormoura]

@fabiormoura could you please fix rubocop offenses as well? Thanks

it's been fixed.

[konalegi]

Merged, going to release it on Monday. Thanks for PR :)