Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the track_total_hits option to the query #801

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Add the track_total_hits option to the query #801

merged 1 commit into from
Jun 25, 2021

Conversation

milk1000cc
Copy link
Contributor

@milk1000cc milk1000cc commented Jun 25, 2021

Return the accurate total hits.

More here: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-your-data.html#track-total-hits


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

@rabotyaga
Copy link
Contributor

Hey @milk1000cc 👋 !
Thank you very much!
Could you please modify a little bit the CHANGELOG line? Something along https://github.com/toptal/chewy/pull/802/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR7

@milk1000cc
Copy link
Contributor Author

milk1000cc commented Jun 25, 2021

CHANGELOG updated.

@rabotyaga rabotyaga merged commit d3b7253 into toptal:master Jun 25, 2021
cyucelen pushed a commit to cyucelen/chewy that referenced this pull request Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants