Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of unnecessary features and integrations #776

Merged
merged 87 commits into from
Mar 26, 2021
Merged

Removal of unnecessary features and integrations #776

merged 87 commits into from
Mar 26, 2021

Conversation

Vitalina-Vakulchyk
Copy link
Contributor

@Vitalina-Vakulchyk Vitalina-Vakulchyk commented Mar 23, 2021 •
edited
Loading

Removed:
will_paginate
resque
mongoid
aws-sdk-sqs / shoryuken
sequel

PR progress:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Updated tests.
  • Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

@Vitalina-Vakulchyk
Remove will_paginate gem from gemfiles
3b4b9a5
@Vitalina-Vakulchyk
Remove will_paginate module from Chewy#Search#Pagination
069060a
@Vitalina-Vakulchyk
Remove will_paginate from lib/chewy.rb
80de8c1
@Vitalina-Vakulchyk
Remove will_paginate from lib/chewy/search.rb
bce4560
@Vitalina-Vakulchyk
Remove spec for Chewy::Search::Pagination::WillPaginate
b90876c
@Vitalina-Vakulchyk
Remove will_paginate_examples.rb for will_paginate module spec
ffe322c
@Vitalina-Vakulchyk
Remove will_paginate specs from config_spec.rb
d78d301
@Vitalina-Vakulchyk
Update CHANGELOG with drop will_paginate support
f97701f
@Vitalina-Vakulchyk
Rubocop it
b9de918
@Vitalina-Vakulchyk
Remove will_paginate comments from /lib/chewy/search.rb
fe9d7c1
@Vitalina-Vakulchyk
Remove resque from gemfile
1991d43
@Vitalina-Vakulchyk
Remove resque from chewy.gemspec
077f5a1
@Vitalina-Vakulchyk
Remove resque from gemfiles
c5f23e2
@Vitalina-Vakulchyk
Remove resque from lib/chewy/strategy.rb
aa796e1
@Vitalina-Vakulchyk
Remove lib/chewy/strategy/resque.rb
39ffa46
@Vitalina-Vakulchyk
Resque: Remove spec/chewy/strategy/resque_spec.rb
1239030
@Vitalina-Vakulchyk
Resque: Remove resque from Readme
99e0d5f
@Vitalina-Vakulchyk
Resque: Remove resque from /lib/chewy/config.rb
b90c3f6
@Vitalina-Vakulchyk
Resque: mark as removed in CHANGELOG
134353d
@Vitalina-Vakulchyk
Mongoid: Remove adapter
7b754cc
@Vitalina-Vakulchyk
Mongoid: Adapt spec/chewy/type/import_spec.rb
501b001
@Vitalina-Vakulchyk
Mongoid: remove spec/support/mongoid.rb
2c7069b
rabotyaga
rabotyaga reviewed Mar 25, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Vitalina-Vakulchyk
Copy link
Contributor Author

@rabotyaga please take a look again.

@Vitalina-Vakulchyk
Copy link
Contributor Author

@dalthon please take a look again

rabotyaga
rabotyaga reviewed Mar 26, 2021
View reviewed changes
spec/spec_helper.rb Outdated Show resolved Hide resolved
rabotyaga
rabotyaga reviewed Mar 26, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Vitalina-Vakulchyk Vitalina-Vakulchyk force-pushed the removal-of-unnecessary-features-and-integrations branch from af465f1 to 04e43a6 Compare March 26, 2021 11:11
dalthon
dalthon approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@dalthon dalthon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Awesome!

@Vitalina-Vakulchyk Vitalina-Vakulchyk merged commit 473f7eb into master Mar 26, 2021
@Vitalina-Vakulchyk Vitalina-Vakulchyk deleted the removal-of-unnecessary-features-and-integrations branch March 26, 2021 11:47
@rabotyaga rabotyaga mentioned this pull request Jul 28, 2021
Closed
cyucelen pushed a commit to cyucelen/chewy that referenced this pull request Jan 28, 2023
@Vitalina-Vakulchyk
Removal of unnecessary features and integrations (toptal#776)
bf6f847
@akshay-apollo akshay-apollo mentioned this pull request Oct 14, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabotyaga rabotyaga rabotyaga approved these changes

@dalthon dalthon dalthon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vitalina-Vakulchyk @dalthon @rabotyaga