Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #722] Remove alias_method_chain, use Module#prepend instead #764

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

dalthon
Copy link
Contributor

@dalthon dalthon commented Feb 24, 2021

Ruby 2.0 already have a better alternative to alias_method_chain which is Module#prepend. (Don't remember exactly when introduced).

There is no reason to continue using alias_method_chain, and it was causing some conflicts with other gems.

Checklist

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests. (not applicable)
  • Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

@dalthon dalthon force-pushed the issue-722-remove_alias_method_chain branch from 56835e2 to beb26ee Compare February 24, 2021 09:04
@dalthon dalthon marked this pull request as ready for review February 24, 2021 09:30
CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants