[FIX-716] Avoid fetching scope data to check if it is blank #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthon
force-pushed
the
avoid-unneeded-fecthing-on-import
branch
from
8ed6ecb
to
a5d2240
Compare
dalthon
force-pushed
the
avoid-unneeded-fecthing-on-import
branch
from
a5d2240
to
b2c4d0c
Compare
AlfonsoUceda
approved these changes
Feb 12, 2021
rabotyaga
reviewed
Feb 12, 2021
| @@ -6,6 +6,8 @@ | |||
|
|
|||
| ### Changes | |||
|
|
|||
| * [#761](https://github.com/toptal/chewy/pull/761): Avoid fetching scope data to check if it is blank ([@dalthon][]) | |||
There was a problem hiding this comment.
Let's follow the contributing guide:
If the change has a related GitHub issue (e.g. a bug fix for a reported issue), put a link to the issue as [#123](https://github.com/toptal/chewy/issues/123):
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the issue raised here: #716
There was some unnecessary, possibly heavy, queries being done.
[Fix #issue-number](if the related issue exists).master(if not - rebase it).