Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace parent-child mapping with a join field #760

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Replace parent-child mapping with a join field #760

merged 1 commit into from
Jan 17, 2022

Conversation

mrzasa
Copy link
Contributor

@mrzasa mrzasa commented Feb 12, 2021 •
edited
Loading

ES 7.0 support: https://www.elastic.co/guide/en/elasticsearch/reference/current/removal-of-types.html#parent-child-mapping-types

Remove parent/child mapping with parent param, replace with join field.

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

@mrzasa mrzasa added the WIP label Feb 12, 2021
@mrzasa mrzasa force-pushed the remove-parent-child-mapping branch from 37cbad3 to aaf0ab2 Compare May 24, 2021 10:42
@mrzasa mrzasa force-pushed the remove-parent-child-mapping branch from 4028637 to c0b0913 Compare June 8, 2021 12:40
@mrzasa mrzasa requested a review from rabotyaga June 8, 2021 13:16
rabotyaga
rabotyaga reviewed Jun 8, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
rabotyaga
rabotyaga reviewed Jun 9, 2021
View reviewed changes
spec/chewy/index/import/bulk_builder_spec.rb Outdated Show resolved Hide resolved
spec/chewy/index/import/routine_spec.rb Outdated Show resolved Hide resolved
queries.sh Outdated Show resolved Hide resolved
queries.sh Outdated Show resolved Hide resolved
queries.sh Outdated Show resolved Hide resolved
lib/chewy/fields/base.rb Show resolved Hide resolved
lib/chewy/index/adapter/orm.rb Outdated Show resolved Hide resolved
lib/chewy/index/import/bulk_builder.rb Show resolved Hide resolved
lib/chewy/index/import/bulk_builder.rb Outdated Show resolved Hide resolved
lib/chewy/index/import/bulk_builder.rb Outdated Show resolved Hide resolved
@mrzasa mrzasa force-pushed the remove-parent-child-mapping branch 2 times, most recently from d662b9c to 8263e1f Compare December 20, 2021 14:59
@mrzasa mrzasa removed the WIP label Dec 20, 2021
@mrzasa mrzasa changed the title Remove parent/child mapping Replace parent-child mapping with a join field Dec 20, 2021
@mrzasa mrzasa marked this pull request as ready for review December 20, 2021 15:29
rabotyaga
rabotyaga approved these changes Jan 6, 2022
View reviewed changes
spec/chewy/index/adapter/active_record_spec.rb Outdated Show resolved Hide resolved
@mrzasa mrzasa force-pushed the remove-parent-child-mapping branch from 2c4860c to 30c2ccc Compare January 12, 2022 10:54
dalthon
dalthon approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@dalthon dalthon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor suggestion, but LGTM

README.md Outdated Show resolved Hide resolved
dalthon
dalthon approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@dalthon dalthon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrzasa
Replace parent-child with a join field.
9c96cfd 
Implement hierarchical structures with Elastic join field, in place of
an obsolete (and removed) parent-child relationships.
@mrzasa mrzasa force-pushed the remove-parent-child-mapping branch from aee65d8 to 9c96cfd Compare January 17, 2022 09:07
@mrzasa mrzasa merged commit 10ff43b into master Jan 17, 2022
@mrzasa mrzasa deleted the remove-parent-child-mapping branch January 17, 2022 09:14
cyucelen pushed a commit to cyucelen/chewy that referenced this pull request Jan 28, 2023
@mrzasa
Replace parent-child with a join field. (toptal#760)
7247b5e 
Implement hierarchical structures with Elastic join field, in place of
an obsolete (and removed) parent-child relationships.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabotyaga rabotyaga rabotyaga approved these changes

@dalthon dalthon dalthon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrzasa @dalthon @rabotyaga